Skip to content

Ensure freshness of settings with project creation

Stan Hu requested to merge sh-ensure-fresh-project-settings into master

Application settings from the database are currently cached locally in the thread for a full minute after the changes are made. That means if an administrator attempts to change the default storages in the admin page, it might take up to a full minute for those changes to take effect.

Since we don't have a great cache invalidation strategy for local caches yet (#36663), the simplest approach to solving this problem would be to expire the local application setting cache whenever we create a project. This causes every project creation to make an additional SELECT call for application_settings.

Closes gitaly#2147 (closed)

Edited by Stan Hu

Merge request reports