Skip to content

Allow numeric emoji names in validation

Dan Jensen requested to merge 210335-fix-handling-of-numeric-emoji-names into master

What does this MR do?

Sometimes the frontend sends numeric emoji names as numbers instead of strings. Previously the backend would raise an ArgumentError when it received a number. This modifies the backend to convert all values to string before validating they are actual emoji names, thereby fixing the bug.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #210335 (closed)

Edited by Dan Jensen

Merge request reports