Rename Duo Code Review depths to Lite and Standard

What does this MR do and why?

Renames the Duo Code Review depths: Deep becomes Standard and Standard becomes Lite, following the naming decision and final copy. Part of https://gitlab.com/gitlab-org/gitlab/-/work_items/639721+

Backend and frontend ship together because standard changes meaning (light before, heavy after). The commits can be reviewed separately:

  1. Backend: renames the flag to duo_code_review_standard_flow, the flow to standard_code_review (already in the AI Gateway and CustomersDot) and the model key to review_merge_request_dap_standard. Quick action, GraphQL and REST values become lite / standard, with no deprecation since they're experiment and beta.
  2. Frontend: the reviewer menu, autocomplete, badges, model selection and settings use the new names.
  3. Lite: renames the interim name Quick to Lite.
  4. Copy: capitalizes Lite and Standard in quick action replies and applies the final copy.

Stored values don't change (0 is the lighter flow, 1 the heavier one), so there's no data migration. Jobs enqueued with deep before the deploy run as Standard.

Local testing

With duo_code_review_standard_flow on and the AI Gateway on main (includes gitlab-org/modelops/applied-ml/code-suggestions/ai-assist!7985 (merged)):

  1. A plain /request_review @GitLabDuo on a project with the Lite default runs code_review on the review_merge_request_dap model setting, and findings are labelled lite.
  2. /request_review @GitLabDuo -lite runs code_review and replies Requested a Lite review from @GitLabDuo.
  3. /request_review @GitLabDuo -standard runs standard_code_review 1.0.0 on review_merge_request_dap_standard, labels findings standard, and replies Requested a Standard review from @GitLabDuo.
  4. With the project default set to Standard, a plain /request_review @GitLabDuo runs standard_code_review.
  5. With Standard not allowed, a saved Standard default is stored as Lite, and -standard is rejected with Failed to find users for '-standard'.
  6. With the flag off, a requested Standard review uses review_merge_request_dap.
  7. A review started with the old deep depth, as a job enqueued before the deploy would be, runs standard_code_review.

Screenshots

Project settings Group settings Admin settings
after_project after_group after_admin
Sidebar re-request Autocomplete Model selection
after_sidebar after_autocomplete after_model
Review badge Lite finding comment Standard finding comment
after_badge after_comment_lite after_comment_standard

How to set up and validate locally

  1. Enable duo_code_review_standard_flow and turn on beta features for the root group.
  2. In the project's merge request settings, check the depth shows Lite (Default) and Standard, and the checkbox says Allow Standard reviews.
  3. On an MR, run /request_review @GitLabDuo -standard and check the workflow runs standard_code_review.
  4. Type /request_review @GitLabDuo - and check autocomplete offers Lite and Standard. The reviewer sidebar re-request menu shows the same two options.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist.

References

Edited by Kinshuk Singh

Merge request reports

Loading
Loading