Remove classic diffs code from merge request pages

What does this MR do and why?

This MR removes code that served the classic diffs app on merge request pages. After !269613 (merged) removed the Rapid Diffs toggle, nothing can mount that app there any more, so this code is unreachable. Nothing changes for users.

It removes:

  • The data the classic app was mounted with (diffs_tab_pane_data and its EE override), the diff batch and linked file URLs the controller built for it, and two helpers that only that data used: show_suggest_popover? and MergeRequestsHelper#default_suggestion_commit_message.
  • The new_blob_path field in the merge request noteable data, which only the classic empty state read, and the skip_legacy_diffs_data option that gated it. The page no longer pays for the Gitaly ref lookup behind it.
  • The pages/projects/merge_requests/diffs bundle and the frontend branches that ran only without a Rapid Diffs app: the diffs page bundle in merge_request_tabs.js, legacy diffs store setup in init_mr_notes.js, and the legacy store choices in the sticky header and discussion counter.
  • The lazy_create_rapid_diffs_app.js module. Without its gon check it was a small wrapper, so it is now the default factory in initMrPage.

The classic ~/diffs Vue app and its stores stay for now, because notes and batch comments still import them. Removing them is the next step.

References

Screenshots or screen recordings

Not applicable. Nothing changes visibly.

How to set up and validate locally

  1. Open the Overview, Commits and Changes tabs of a merge request and switch between them. Each tab loads, and Rapid Diffs renders on Changes.
  2. Open a diff comment from the review drawer. The page goes to that comment.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stanislav Lashmanov

Merge request reports

Loading
Loading