Skip to content

Resolve "Status Page MVC: JSON format and endpoints"

Sean Arnold requested to merge 207935-status-page-json-changes into master

What does this MR do?

This makes the changes mentioned in #207935 (closed)

  • Changing incidents list to be an object containing an incidents array
  • Adding links to the Incident object (with details inside)
  • Prefix urls with /data

Screenshots

http://pleitzen-status-page-mvc.s3-website-eu-west-1.amazonaws.com/data/list.json:

{
   "incidents" : [
      {
         "updated_at" : "2020-02-21T07:10:46.097Z",
         "description" : "",
         "created_at" : "2020-02-21T07:05:38.261Z",
         "title" : "Wrong issue order <gl-emoji title=\"warning sign\" data-name=\"warning\" data-unicode-version=\"4.0\">⚠</gl-emoji>",
         "id" : 3,
         "links" : {
            "details" : "data/incident/3.json"
         },
         "state" : "closed"
      },

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #207935 (closed)

Edited by Peter Leitzen

Merge request reports