Backport of 'Re-evaluate SAML admin groups on Admin Mode re-entry'

What does this MR do and why?

Backports Re-evaluate SAML admin groups on Admin Mode re-... (!264737 - merged) • Michael Eddington • 19.6 to 19.5, at the request of the issue thread.

With SAML admin_groups configured, re-entering Admin Mode through SAML only checked that the SAML identity matched the signed-in user. A user removed from the IdP admin group kept admin access, and could keep entering Admin Mode while their IdP session was still active. Re-entry now syncs the user from the SAML assertion, as sign-in does. It refuses Admin Mode when the synced user is no longer an active admin, and redirects revoked users to the home page instead of the admin-only Admin Mode page.

This is a clean cherry-pick of the squash commit 3971b035 (git cherry-pick -x). The four changed files are identical to the merged MR on master.

Related issue: Active SSO session bypasses the six-hour Admin ... (#630537) • Michael Eddington • 19.7

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the E2E Omnibus GitLab EE pipeline (triggered by thee2e:test-on-omnibus-ee job) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

🤖 Generated with Claude Code

Edited by Michael Eddington

Merge request reports

Loading
Loading