[19.4] Backport of 'Reorder code-owner gate to skip can_push_to_branch? on large pushes'

What does this MR do and why?

Backport of !267354 (merged).

EE DiffCheck#validate_code_owners? runs once per ref and called the expensive user_access.can_push_to_branch? (per-ref Redis + SQL) before the cheap code-owner-approval gate. On a push touching many refs this recomputed protection and push permission for every ref.

This reorders the guards cheapest-first: updated_from_web? (in memory), then branch_requires_code_owner_approval? (free when code-owner approval is not configured), then can_push_to_branch?. The boolean result is unchanged; branches that do not require code-owner approval no longer pay the per-ref Redis and SQL cost.

Cherry-picked cleanly with no conflicts; the backport diff is identical to the original MR.

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/637931

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Marc Shaw

Merge request reports

Loading
Loading