Skip to content

Refactor pdf_viewer to sfc

What does this MR do?

As a part of the jestodus effort, this MR

migrates: spec/javascript/blob/pdf/index_spec.js

to jest: spec/frontend/blob/pdf/index_spec.js

This MR also refactors app/assets/javascripts/blob/pdf/index.js to not use a template string but to return a SFC component

I initially had planned to convert all the spec in blob to jest in one go but is better to split the work across several MRs

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Part of #194207 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports