Skip to content

Correctly send notification on pipeline retry

What does this MR do?

In !16951 (merged) we found an issue in https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/services/ci/update_ci_ref_status_service.rb#L25, in particular the >= excludes the case when a pipeline is retried. This MR uses > instead of >= to fix this issue and correctly update the ref status + send a notification on pipeline retry.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #209783 (closed)

Edited by 🙈 jacopo beschi 🙉

Merge request reports