Skip to content

Replace jquery dropdowns across analytics

What does this MR do?

Replaces the remaining jquery / bootstrap dropdowns in analytics with the new GlNewDropdown component

  • Removes the dependency on jquery in the analytics space
  • Updates specs
  • Replaces done callbacks in specs with promises

Screenshots

Before After
Screen_Shot_2020-05-26_at_12.24.38_am Screen_Shot_2020-05-21_at_6.58.14_pm
Screen_Shot_2020-05-26_at_12.24.30_am Screen_Shot_2020-05-21_at_6.58.25_pm
Screen_Shot_2020-05-26_at_12.24.04_am Screen_Shot_2020-05-21_at_6.58.57_pm
Screen_Shot_2020-05-26_at_12.24.12_am Screen_Shot_2020-05-21_at_6.59.16_pm
Screen_Shot_2020-05-26_at_12.12.17_am Screen_Shot_2020-05-26_at_12.11.07_am

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #198033 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports