Skip to content

Fix extra border on custom stage form groups

Ezekiel Kigbo requested to merge 207966-fix-extra-border-on-form-legend into master

What does this MR do?

Fixes a minor extra border that was appearing around form group elements. The form-group needs an extra label-for attribute to render the group with a div and label instead of the default fieldset and legend.

No changelog added since this is still behind the :customizable_cycle_analytics feature flag

Fixes #207966 (closed)

Screenshots

Before After
Screen_Shot_2020-03-08_at_12.01.10_pm Screen_Shot_2020-03-08_at_12.10.29_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #207966 (closed)

Edited by Ezekiel Kigbo

Merge request reports