Backport of 'Keep the relative URL root in streamed Rapid Diffs paths'
What does this MR do and why?
This MR backports !266586 (merged) to 19.4.
On instances served under a relative URL root, Rapid Diffs streamed every file after the first one with paths that lacked that root, so expanding lines and links such as View file returned 404. The fix resolves the URL options before anything is streamed, because Rack::URLMap from config.ru takes the root back out of SCRIPT_NAME once the committed response returns through it.
19.4 is affected because it has !253635 (merged), which keeps the Rack env alive past the committed response. The cherry-pick applied cleanly, with no conflicts.
Resolves #637180 (closed) for this version.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.