Draft: Remove the projectFullPath argument of ciPipelineStatusesUpdated
What does this MR do and why?
ciPipelineStatusesUpdated accepts either projectId or projectFullPath. The path argument was added in ef16d576 so that the commit pipelines tab could subscribe with the same identifier as its list query.
No frontend code uses it now. Both subscribers send projectId:
- the commit pipelines tab (
commit_pipelines_list.vue), withprojectIdandsha - the project pipelines list (
pipelines_app.vue), withprojectId
But every pipeline transition still triggers two topics keyed by the full path, which nobody in our code subscribes to. This MR removes the argument and those two triggers. projectId is required again, and the subscription is the same as before ef16d576.
Compatibility
- Our frontend: not affected, during a rolling deploy too. It only subscribes with
projectId. - External clients that subscribe by path: their subscription now fails validation.
ciPipelineStatusesUpdatedis marked as an experiment, so the argument is removed without a deprecation period. The changelog entry says so.
Why now
This is the first MR of a stack about subscription rate limits. With only projectId topics, the next MR can scope the ciPipelineStatusesUpdated rate limit from the topic arguments, like the other rate limited subscriptions, and halve its events per transition.
How to set up and validate locally
bin/rspec spec/graphql/subscriptions/ci/pipelines/statuses_updated_spec.rb spec/graphql/graphql_triggers_spec.rbMR acceptance checklist
Evaluate this MR against the MR acceptance checklist.
References
- Part of https://gitlab.com/gitlab-org/gitlab/-/work_items/630854 (reduce dropped GraphQL subscription events)
- Next in the stack, the rate limit declared on the subscription: !264287 (merged)
- Added the argument being removed: ef16d576