Remove cache_list_mr_on_group_api_responses feature flag

Removes the cache_list_mr_on_group_api_responses flag and the bot-only response cache it gated on GET /groups/:id/merge_requests. The flag has been off on GitLab.com since June 2026 because of its Redis memory use, and we are not going to cache this endpoint, so it now always renders directly, which is what it already does with the flag off.

Detailed context for AI agents

Change

  • lib/api/merge_requests.rb: the group endpoint drops the flag check, the bot-only skip_cache logic and the render_merge_requests(..., ttl: 30.minutes) call. It always calls present merge_requests, **options, the flag-off path on master.
  • render_merge_requests stays: the project list endpoint (GET /projects/:id/merge_requests) still uses it with its default 8 hour TTL.
  • config/feature_flags/gitlab_com_derisk/cache_list_mr_on_group_api_responses.yml is deleted.
  • spec/requests/api/merge_requests_spec.rb: the group endpoint's caching context (cached and invalidated bot responses, flag-off context) is removed. With no cache left, a bot request is an ordinary request, so nothing replaces it.

Flag history

  • Introduced by !226653 (merged) for #585222 (closed), rollout issue #594433 (closed).
  • Enabled for two groups on 2026-06-09 and turned off globally on 2026-06-12 because of Redis memory consumption. It has stayed off since.
  • Flag-off behaviour is kept, so this is a no-op on GitLab.com. Self-managed default was false.

Changelog

Changelog: other (default-off flag removed together with the code it gated).

After merge

  • /chatops run feature delete cache_list_mr_on_group_api_responses --dev --pre --staging --staging-ref --production
  • Close #594433 (closed).

The group endpoint investigation in #631601 decided against response caching for this endpoint. !266181 (merged) touches the same lines of the group endpoint, so whichever lands second needs a small rebase.

Verification

  • spec/requests/api/merge_requests_spec.rb:1594 (the whole GET /groups/:id/merge_requests block): 133 examples, 0 failures, in an isolated spec slot.
  • ci:job_tokens:check_policies, gitlab:openapi:v3:check_docs, gitlab:cells:routes:updated_check and gitlab:permissions:validate pass on this commit. They were skipped in the local pre-push hook only because the git worktree has no config/database.yml.
Edited by Marc Shaw

Merge request reports

Loading
Loading