Skip to content

Use packaged script from GitLab accessibility image

drew stachon requested to merge a11y-gitlab-script into master

What does this MR do?

This replaces the bash script written directly in the a11y template with a call to a bash script file packaged in the new accessibility image.

This configuration template will produce an HTML accessibility report for each URL in $a11y_urls, as well as a single accessibility.json artifact that can be fetch and parsed programatically by frontend features.

This feature doesn't run in pipelines by default, even with the template included. a11y_urls must be specifically set in order for the job to run.

I set up a test project pulling the GitLab Accessibility CI template off this feature branch, and the job with artifacts is viewable here: https://gitlab.com/drewcimino/a11y-scanning/-/jobs/466028486. I'm not sure if there's a better way to test a CI template in our project setup, but this seems sufficient to me for the purposes of this MR.

The accessibility project that the image comes from can be found here: https://gitlab.com/gitlab-org/ci-cd/accessibility

Screenshots

Screen_Shot_2020-03-10_at_15.06.34

Screen_Shot_2020-03-10_at_15.06.57

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • ~~Label as security and @ mention @gitlab-com/gl-security/appsec~~
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jackie Porter

Merge request reports