Skip to content

Move whitelist specs

Reuben Pereira requested to merge move-whitelist-specs into master

What does this MR do?

UrlBlocker calls UrlWhitelist methods, so url_whitelist_spec.rb is the right place for specs which check for the correct behavior of the UrlWhitelist methods.

This MR moves some specs from the url_blocker_spec.rb file to the url_whitelist_spec.rb file. It also improves the stub_domain_resolv spec helper method.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports