BulkIndexer change _routing -> routing to support ES 7
What does this MR do?
In ES 6.x onwards _routing is deprecated in the bulk API but in 7.x it
was removed completely. While this is sadly not clearly documented it's
referenced in a few places like
https://discuss.elastic.co/t/deprecated-field-routing-used-expected-routing-instead/115951
and we also learnt this when fixing the Go indexer at
gitlab-elasticsearch-indexer!34 (closed)
I have tested this version works for 6.5.1 , 6.8.1 and 7.5.1 .
Additionally since this is the same way that our
Go gitlab-elasticsearch-indexer is behaving this should be a safe
change.
See #208717 (comment 300201720)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team