Skip to content

Move EE Users related specs to correct folder

Tan Le requested to merge tancnle/move-ee-users-service-specs into master

What does this MR do?

Move EE Users related specs to correct folder. This change ensures we have specs located in more predictable folder structure as per corresponding app code.

find ee/app/services/**/users/*.rb

ee/app/services/ee/users/block_service.rb
ee/app/services/ee/users/build_service.rb
ee/app/services/ee/users/create_service.rb
ee/app/services/ee/users/destroy_service.rb
ee/app/services/ee/users/migrate_to_ghost_user_service.rb
ee/app/services/ee/users/update_service.rb

Before

find ee/spec/services/**/users/*.rb

ee/spec/services/ee/users/block_service_spec.rb
ee/spec/services/ee/users/create_service_spec.rb
ee/spec/services/ee/users/destroy_service_spec.rb
ee/spec/services/users/build_service_spec.rb
ee/spec/services/users/migrate_to_ghost_user_service_spec.rb
ee/spec/services/users/update_service_spec.rb

After

find ee/spec/services/**/users/*.rb

ee/spec/services/ee/users/block_service_spec.rb
ee/spec/services/ee/users/build_service_spec.rb
ee/spec/services/ee/users/create_service_spec.rb
ee/spec/services/ee/users/destroy_service_spec.rb
ee/spec/services/ee/users/migrate_to_ghost_user_service_spec.rb
ee/spec/services/ee/users/update_service_spec.rb

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le

Merge request reports