Remove external dependencies flag from Iterable workers

What does this MR do and why?

Onboarding::CreateIterableTriggerWorker and Onboarding::AddOnSeatAssignmentIterableTriggerWorker were marked with worker_has_external_dependencies! because they call CustomersDot.

Scalability's guidance is that CustomersDot is not an external dependency, because it is a service we own and choose (discussion). The flag is for services outside our control, such as user-configured webhooks. GitlabSubscriptions::Trials::ApplyTrialWorker already follows this.

This MR:

  • Removes worker_has_external_dependencies! from both workers.
  • Regenerates all_queues.yml to match.
  • Adds a comment to SyncSeatLinkRequestWorker explaining why it keeps the flag.

Both workers stay urgency :low. The only effect is the external_dependencies metrics label and the error alerting thresholds, which now match other internal workers. Nothing changes in the jobs themselves, and there is no feature flag.

SyncSeatLinkRequestWorker keeps the flag. It runs on self-managed instances and reaches CustomersDot over the customer's network, which is outside our control.

References

How to set up and validate locally

  1. Run bin/rake gitlab:sidekiq:all_queues_yml:check. It passes.
  2. In a Rails console, run Onboarding::CreateIterableTriggerWorker.worker_has_external_dependencies?. It returns false.
  3. Run the same check for Onboarding::AddOnSeatAssignmentIterableTriggerWorker. It also returns false.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

🤖 Generated with Claude Code

Edited by David Hamp-Gonsalves

Merge request reports

Loading
Loading