Loading
Remove old Orbit GraphQL fields and update Orbit API docs
What does this MR do and why?
Removes the old GraphQL fields and mutations that Query.orbit replaced, which !261894 (merged) announced. This MR covers only those removals, not any other part of that follow-up. It also lists each Orbit REST endpoint's status in the API docs (see !264917 (merged)) and corrects the offering line.
References
- Follows !261894 (merged) and !264917 (merged)
- Endpoint plan: gitlab-org/orbit/knowledge-graph#263
How to validate
- Run
bundle exec rspec ee/spec/requests/api/graphql/mutations/analytics ee/spec/requests/api/graphql/analytics/orbit ee/spec/graphql/ee/types ee/spec/requests/api/graphql/group ee/spec/requests/api/graphql/groups_query_spec.rb. - Confirm
doc/api/graphql/referencehas noknowledgeGraphEnabled,orbitAccessororbitTrial.
Agent context
- The excluded-group mutations and resolver moved because
Query.orbitand theorbit*mutations reused the removed classes, so deleting them outright would break those. - Request specs for
orbitTrialandorbitAccesswere ported toGroup.orbit.trialandGroup.orbit.access, and the excluded-groups query spec was kept onQuery.orbit.public/-/graphql/introspection_result.jsonis regenerated. - Removed fields:
Group.knowledgeGraphEnabled,knowledgeGraphAvailable,orbitAccess,orbitTrial,Query.knowledgeGraphExcludedNamespaces, and the mutationsknowledgeGraphExcludedNamespaceCreate/Destroy. All wereexperimentfields, so no deprecation period applies. - No frontend callers: nothing under
app/assetsoree/app/assetsqueries them. TheknowledgeGraphEnabledkey ingraph_transform.jsis a local object property fed fromorbit.enabled. - The
orbitExcludedGroupCreate/Destroymutations andorbit.excludedGroupssubclassed or reused the removed classes, so the code moved intoMutations::Analytics::Orbit::ExcludedGroup*andResolvers::Analytics::Orbit::ExcludedGroupsResolver. Their specs lost the dual old/new loops. - Specs for the removed fields were deleted. The remaining ones that selected
knowledgeGraphEnableduseorbit { enabled }. - Docs: new "Endpoint status" table in
doc/api/orbit.mdmatching thelifecyclesettings inee/lib/api/orbit/data.rb, Experiment status on the grep section, and offering now lists Self-Managed and Dedicated. The two removed mutations are dropped from the fine-grained token doc. The Duo context page linked the deleted page, so it now linkshttps://docs.gitlab.com/orbit/. GraphQL reference docs regenerated. - Run on a Caproni slot: the orbit, group, mutation and type specs pass; Rubocop and markdownlint pass.
- The stable-branch reverts (!265515 (merged), !265516 (merged)) are merged. This MR targets
master. - Branch pipelines still run;
[skip ci]only covers MR pipelines.
Edited by Dmitry Gruzd