Skip to content

Audit number of required approvals changes at project level

Tan Le requested to merge 7531-audit-approval-list-changes into master

What does this MR do?

This MR will ensure audit event is recorded both in DB and log file when user successfully update no. of required approvals at Project level. We would like to capture changes to ApprovalProjectRule model and surface it under Project audit events page. The audit event will be recorded for update issued via both App and API.

Extracted from !25583 (closed) to reduce scope.

Parent issue #7531 (closed)

Screenshots

Project-level

(Project > Settings > Audit Events)

Screen_Shot_2020-03-05_at_2.59.17_pm

Instance-level

(Admin Area > Monitoring > Audit Log)

Screen_Shot_2020-03-05_at_3.00.21_pm

How the event attributes are mapped to the Audit Events view

Screen_Shot_2020-02-23_at_8.38.58_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le

Merge request reports