Use ReplicateRepository when moving repo storage
What does this MR do?
- Replaces the use of the Gitaly RPC FetchInternalRemote with ReplicateRepository
- Removes special handling of same storage moves as ReplicateRepository already handles this (deletes RepositoryAlreadyMoved)
- Fixes bug in TestEnv that would delete the second_storage directory. It's use is normally mocked, but the end-to-end tests here for the new RPC now use it
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by James Fargher