Skip to content

Refactor container repository api

Steve Abrams requested to merge cleanup-container-api into master

What does this MR do?

This MR cleans up the params block in the project_container_repositories api. It was using a nested set of conditionals to create the same behavior that Grape's at_least_one_of helper gives. I implemented the old code and recently found this helper, so I decided to come back and clean it up.

I do not believe there is a need for any tests or change in tests since this is a straight refactor and no behavior is expected to change.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports