Skip to content

Resolve "Use absolute path when unpacking command"

Vijay Hawoldar requested to merge 33773-use-absolute-path-when-unpacking into master

What does this MR do?

Changes the backup manager to stop using basename when inspecting the BACKUP env var in favour of using check_path_traversal!. This means that if someone tries to use a path in BACKUP they will now get an error, because only a filename is supported as documented here.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #33773 (closed)

Edited by Vijay Hawoldar

Merge request reports