Backport of 'Build nested Jira request URLs from the configured API URL'

What does this MR do and why?

Backport of !262913 (merged) to this stable branch. The cherry-pick applied cleanly.

When Jira reports an issue self URL with a different host or context path than the configured API URL, jira-ruby builds the remote link requests from that reported URL. The request then goes to the reported host and fails with HTTParty::UnsafeURIError, so GitLab cannot create or update the remote link on the Jira issue.

The fix replaces the issue self with a path built from the client configuration, and drops self from remote links found on the issue, so every nested request uses the configured base URL. A guard in Gitlab::Jira::HttpClient refuses any request whose scheme, host or port differs from the configured URL.

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/607785

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the E2E Omnibus GitLab EE pipeline (triggered by thee2e:test-on-omnibus-ee job) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Merge request reports

Loading
Loading