Move the Orbit trial end to the group billing account

Jean-Gabriel Doyonrequested to merge
orbit-billing-e2e-run-fixes into master

What does this MR do and why?

Fixes for the bugs that the automated Orbit monetization E2E run finds.

Related: https://gitlab.com/gitlab-org/orbit/knowledge-graph/-/work_items/1399

Bug Fix
InstanceAccount#end_trial_if_over raised NoMethodError (trials_in_use?): !263080 (merged) removed the instance trial-end helpers but kept the shared method Move end_trial_if_over to GroupAccount, the only account that ends trials. No caller changes: only DisableEndedTrialsWorker calls it, on GitLab.com

How to validate

  • ee/spec/lib/analytics/orbit and ee/spec/workers/analytics/orbit: 206 examples pass; local undercoverage is clean.
  • instance_account_spec.rb pins that an instance account has no end_trial_if_over.
Edited by Jean-Gabriel Doyon

Merge request reports