Container expiration policy settings hide form on API error
What does this MR do?
This MR removes the toast notification that appears when there is an error in fetching the project API and move the message to a permanent alert that replaces the form.
Benefits:
- the user does not see an error toast when the container registry expiration policy is collapsed
- the message is permanent and is shown even if the user opens the section after he did something else in the page
- the form is hidden, this way we avoid possible errors and de-synchronization with the data
Screenshots
Screencap
Before
After
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #199998 (closed)
Edited by Nicolò Maria Mezzopera