Loading
Backport of 'Workhorse: return 429 when Gitaly rejects GetArchive with ResourceExhausted'
What does this MR do and why?
Backports !262112 (merged) to 19.5. When Gitaly's concurrency limiter rejects an archive request, Workhorse now returns 429 Too Many Requests instead of 500, so clients can back off. Related issue: #633785 (already handled on master). This backport is needed so clients pulling archives under Gitaly load on 19.3–19.5 get a retryable 429 instead of a 500 that looks like a server bug, and the failure stays non-cacheable.
The cherry-pick applied cleanly. Tests: go test ./internal/git/... from workhorse/.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
E2E Omnibus GitLab EEpipeline (triggered by thee2e:test-on-omnibus-eejob) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.
Edited by Dmitry Gruzd