Skip to content

Stringify sidekiq job args in logs

Craig Furman requested to merge craigf/stringify-logged-job-args-take2 into master

What does this MR do?

If these logs are sent to Elasticsearch, it will not be able to process nested object fields, as this causes a type mismatch with scalar elements in the same array across log lines.

This is a second attempt, as the first (reverted) one modified the actual job object that was used by sidekiq.


Related: https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8931

2nd attempt at: !26075 (merged)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports