Backport: Cache foundational flow catalog item per request
What does this MR do and why?
Backport of !261841 (merged) to 19-5-stable-ee.
Duo Code Review through the Duo Agent Platform can fail with a 403 on POST /api/v4/ai/duo_workflows/code_review/add_comments until the instance is restarted. Each Puma worker keeps the foundational flow catalog item it looked up first for its whole life. A worker that looked up the Code Review flow before it was seeded keeps "not found", so the DAP Code Review check fails in that worker. Retries only help when they reach a different worker.
This change caches the FoundationalFlow#catalog_item lookup per request (Gitlab::SafeRequestStore) instead of memoizing it on the process-wide instance, and removes the spec workarounds that are no longer needed.
The commit applies cleanly to 19-5-stable-ee and is identical to the change merged to master in !261841 (merged).
Request for help: https://gitlab.com/gitlab-com/request-for-help/-/work_items/5457
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
E2E Omnibus GitLab EEpipeline (triggered by thee2e:test-on-omnibus-eejob) has succeeded. If it has failed (or shows warnings), investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.