Skip to content

Regression: Infinite Spinner on error detail page

David O'Regan requested to merge oregand/gitlab:118503 into master

What does this MR do?

This merge fix's #118503 (closed)

We wait for the Apollo query for 10 seconds or 5 polls at 2 seconds each, and if no data is resolved or no errors are seen, we cancel the query and show a warning flash for user feedback.

Screenshots

Screenshot_2020-02-28_17-05-31

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports