Skip to content

Remove staging from commit workflow in the Web IDE

Himanshu Kapoor requested to merge 196609-remove-staging into master

What does this MR do?

Removes staging from the commit workflow in the Web IDE. Issue: #196609 (closed)

Note: This MR only removes staging from the workflow in the view in the spirit of shipping the user facing change faster. Internally, everything is still staged by default before committing. Removing all staging functionality internally is a massive undertaking, and it would be advisable to do it over multiple releases as multiple tech debt tasks. As an example, if you search for the word 'stage' in the ide folder, there are over 750 occurrences, all of which will need to be removed or replaced as a part of the tech debt.

I will create follow up issues to clear the tech debt that arises as a result of removal of this feature.

Screenshots

Description Before After
Modification tooltip + footer text below commit button Screenshot_2020-03-03_at_10.09.35_AM Screenshot_2020-03-03_at_10.10.07_AM
New file tooltip Screenshot_2020-03-03_at_10.11.01_AM Screenshot_2020-03-03_at_10.10.55_AM
Collapsed folder tooltip Screenshot_2020-03-03_at_10.10.27_AM Screenshot_2020-03-03_at_10.10.20_AM
Changes tab Screenshot_2020-03-03_at_10.11.26_AM Screenshot_2020-03-03_at_10.11.48_AM
Discard all warning Screenshot_2020-03-03_at_10.13.18_AM Screenshot_2020-03-03_at_10.13.49_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports