Drop the /promote success message when promotion fails

What does this MR do and why?

A legacy /promote note that fails no longer reports "Promoted issue to an epic." next to the error.

The /promote message now comes from success_msg, like the other type change messages. remove_type_change_success_message strips it when the update fails. message_for_status also applies the strip when the failed update params contain promote_to_epic.

This MR has no flag. It only removes a success message that was wrong on a failed promotion.

References

How to set up and validate locally

  1. Add a note with /promote to an issue where promotion fails.
  2. quickActionsStatus.errorMessages has the promotion error.
  3. messages no longer has "Promoted issue to an epic.".
  4. Promote an issue that can be promoted. The success message is still there.

Specs:

  • ee/spec/requests/api/graphql/mutations/notes/create/note_spec.rb
  • ee/spec/services/quick_actions/interpret_service_spec.rb

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist.

Generated with Claude Code

Edited by Alexandru Croitor

Merge request reports

Loading
Loading