Fix workspace clone command for non-ASCII branch names

Pavan Kumar Sadashivrequested to merge
gitlab-community/gitlab-org/gitlab:hrlpavan-596326-fix-workspace-clone-non-ascii-branch into master

What does this MR do and why?

Creating a workspace from a branch containing non-ASCII characters (such as feature/günter-überarbeitung) fails during project cloning because InternalPoststartCommandsInserter escapes project_ref using Shellwords.shellescape(project_ref) (which prepends \ to non-ASCII UTF-8 bytes) and interpolates it into --branch "%<project_ref>s" in internal_poststart_command_clone_project.sh. Inside double quotes in /bin/sh, \ before non-ASCII characters is preserved literally, causing git clone to look for a branch containing literal backslashes.

This MR removes the surrounding double quotes around %<project_ref>s in internal_poststart_command_clone_project.sh so the Shellwords.shellescape-escaped value is interpreted in an unquoted shell context as intended.

References

How to set up and validate locally

  1. Run bundle exec rspec ee/spec/lib/remote_development/workspace_operations/create/internal_poststart_commands_inserter_spec.rb

Merge request reports