Handle failed dependency location requests

Arjun Singhrequested to merge
gitlab-community/gitlab-org/gitlab:603011-dependency-location-fetch-error into master

What does this MR do and why?

When the dependency locations query fails, DependencyLocationCount throws an unhandled error. Its locations dropdown also stays in the searching state, so the spinner never resolves. This was split out of !240039 (merged) as a follow-up, see #603011.

This MR wraps fetchData in try/catch/finally, using the same pattern as the sibling DependencyRefCount component:

  • On failure, it shows an alert: "There was a problem fetching the locations for this dependency." The error is passed to createAlert with captureError: true, so it's still reported.
  • loading is always reset in finally, so the dropdown stops searching whether the request succeeds or fails.

References

Closes #603011

Screenshots or screen recordings

No visual change on success. On failure, the standard danger alert appears, and the dropdown stops showing the spinner.

How to set up and validate locally

  1. Go to a group's Secure > Dependency list and find a dependency with locations.
  2. In the browser developer tools, block the GraphQL request (or make it fail), then open the locations dropdown.
  3. Before this change: the spinner keeps spinning and an unhandled error is logged. After this change: an alert appears and the spinner stops.

Specs: yarn jest ee/spec/frontend/dependencies/components/dependency_location_count_spec.js. All 18 tests pass. The two new failure tests fail against master.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports