Remove unused attr_reader Epics::TransferService#epic_created_events

Kerri Millerrequested to merge
kerrizor/remove-unused-epic-created-events into master

Summary

Removes the unused attr_reader :epic_created_events from ee/app/services/epics/transfer_service.rb.

The backing instance variable @epic_created_events is never assigned or read anywhere in the codebase, so the private reader is dead code.

Related to #542966 (closed)

Verification

This attribute was verified as unused by:

  • keela --type attributes flagged it as unused
  • Grep search found no callers (epic_created_events appears only on the attr_reader line)
  • The ivar @epic_created_events is never assigned or read
  • No metaprogramming patterns reference it
  • No spec coverage references the attribute

Cascade Removals

None - this was a standalone removal.

Metrics

Source File Complexity (flog)

Metric Before After Improvement
File flog total 66.6 65.6 -1.0 (1.5%)
Attribute flog score ~1.0 N/A -1.0 removed

Spec File Complexity (flog)

Metric Before After Improvement
Spec file flog total N/A N/A 0 (no spec references the attribute)
Spec block flog score N/A N/A 0 removed

Combined Flog Summary

File Flog Removed
ee/app/services/epics/transfer_service.rb 1.0
(no spec file) 0
Total 1.0

Test Suite Impact

  • Specs removed: 0 examples (the attribute had no spec coverage)
  • Spec file: none
  • Time saved per run: 0.00 seconds

The existing service spec (ee/spec/services/epics/transfer_service_spec.rb, 12 examples) still passes unchanged.

Estimated CI Savings

Estimate Pipelines/Month Time Saved Cost Saved/Month Cost Saved/Year
Pessimistic 15,000 0.00 hrs/month $0.00 $0.00
Moderate 30,000 0.00 hrs/month $0.00 $0.00
Optimistic 50,000 0.00 hrs/month $0.00 $0.00

No spec was removed, so there is no CI time saved. The value here is dead-code reduction (-1.0 flog, -1 line).

Files Modified

  • ee/app/services/epics/transfer_service.rb (attr_reader removed - 1 line)
  • scripts/lint/keela_baseline.yml (entry removed)

Related

  • Related to #542966 (closed) (Improve unused code removal workflow)
  • Part of dead code cleanup effort
  • Attribute was listed in scripts/lint/keela_baseline.yml

Merge request reports