Fix rendering of duplicate system notes for weight changes
What does this MR do?
Fixes duplicate system notes rendered for weight change events. re #195871 (closed)
This was possible because synthetic weight note did not have a pre-generated discussion_id, so it generated different
discussion_ids, thus rendering the note twice.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.9
marked the checklist item Changelog entry as completed
added 44 commits
-
42716b49...b8e1ad6a - 43 commits from branch
master - 051f716e - Fix rendering of duplicate system notes
-
42716b49...b8e1ad6a - 43 commits from branch
added workflowin dev label and removed workflowready for development label
removed [deprecated] Accepting merge requests label
added 97 commits
-
6ad87c07...4b383fa1 - 96 commits from branch
master - ca8faaa0 - Fix rendering of duplicate system notes
-
6ad87c07...4b383fa1 - 96 commits from branch
added 44 commits
-
77f6527c...6f4bb03a - 43 commits from branch
master - c3fc9cf4 - Fix rendering of duplicate system notes
-
77f6527c...6f4bb03a - 43 commits from branch
added database databasereview pending labels
added 59 commits
-
e509906d...c118dd50 - 58 commits from branch
master - d5957a5a - Fix rendering of duplicate system notes
-
e509906d...c118dd50 - 58 commits from branch
@pderichs would you mind to review this please?
assigned to @pderichs
- Resolved by Patrick Derichs
Thanks and great work @acroitor!
I just had two questions / comments
- Last reply by Alexandru Croitor
unassigned @pderichs
added 272 commits
-
9950c707...abda9897 - 271 commits from branch
master - 9b564816 - Fix rendering of duplicate system notes
-
9950c707...abda9897 - 271 commits from branch
assigned to @pderichs
- Resolved by Alexandru Croitor
Thanks @acroitor! Just a few suggestions, let me know what you think
- Last reply by Alexandru Croitor
unassigned @pderichs
removed database label
added 74 commits
-
eab0db6a...2459f6b8 - 73 commits from branch
master - 25b01cb5 - Fix rendering of duplicate system notes
-
eab0db6a...2459f6b8 - 73 commits from branch
removed databasereview pending label
assigned to @pderichs
added 19 commits
-
1e5c65a1...236fb31b - 18 commits from branch
master - 061e27c8 - Fix rendering of duplicate system notes
-
1e5c65a1...236fb31b - 18 commits from branch
Thanks @acroitor! Awesome work! Had a few minor suggestions for your consideration.
This LGTM
unassigned @pderichs
- Resolved by Alexandru Croitor
@cablett mind taking a look ?
- Last reply by Alexandru Croitor
assigned to @cablett
- Resolved by Alexandru Croitor
@wlsf82 review roulette suggests you may want to take a look as well ?
- Last reply by Alexandru Croitor
assigned to @wlsf82
unassigned @cablett
added 136 commits
-
2c8a2c09...d7dd316f - 135 commits from branch
master - 9812c07b - Fix rendering of duplicate system notes
-
2c8a2c09...d7dd316f - 135 commits from branch
@jameslopez would you mind running the BE maintainer review please ? Thank you.
assigned to @jameslopez
- Resolved by Alexandru Croitor
Thanks @acroitor - left some minor comments :)
- Last reply by Alexandru Croitor
unassigned @jameslopez
assigned to @jameslopez
unassigned @wlsf82
enabled an automatic merge when the pipeline for 0255143c succeeds
@jameslopez last pipeline failed due to changing
be_falseytobe falsefixed it here !26014 (diffs)added 38 commits
-
2a13ce5d...9f8873df - 37 commits from branch
master - 384e2ab9 - Fix rendering of duplicate system notes
-
2a13ce5d...9f8873df - 37 commits from branch
added 152 commits
-
384e2ab9...fa534442 - 151 commits from branch
master - 633ab253 - Fix rendering of duplicate system notes
-
384e2ab9...fa534442 - 151 commits from branch
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Sean Carroll ( @sean_carroll)Jarka Košanová ( @jarka)test Quality for spec/features/*Walmyr Lima e Silva Filho ( @wlsf82)No maintainer available Generated by
enabled an automatic merge when the pipeline for 2e77b2a9 succeeds
mentioned in commit 1ae9e05f
added workflowverification label and removed workflowin dev label
mentioned in issue gitlab-com/www-gitlab-com#5276 (closed)
added workflowstaging label and removed workflowverification label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
