Clean up change_dap_land_default_credits experiment (invalidated)

Roy Liurequested to merge
glforge/632416-change-dap-land-default-credits-cleanup into master

What does this MR do and why?

The change_dap_land_default_credits experiment is invalidated. This MR reverts to the pre-experiment (control) code path.

Tests

All three spec suites pass locally:

bundle exec rspec ee/spec/helpers/billing_plans_helper_spec.rb
# 86 examples, 0 failures

bundle exec rspec ee/spec/services/gitlab_subscriptions/add_on_purchases/gitlab_com/provision_service_spec.rb
# 62 examples, 0 failures

yarn jest ee/spec/frontend/groups/billing/components/components_with_dap_monthly_commit/dap_monthly_credit_card_spec.js
# Tests: 49 passed, 49 total

Grep gate (zero matches for all four experiment identifiers across the repo):

  • change_dap_land_default_credits → 0 matches
  • ChangeDapLandDefaultCreditsExperiment → 0 matches
  • click_purchase_credits_dap_land_sku → 0 matches
  • finish_purchase_credits_dap_land_sku → 0 matches

Validation steps

The experiment and its feature flag are removed by this MR. There is no flag to toggle for validation.

  1. Verify the DAP monthly credit card still renders on /-/groups/<group>/-/billings for a free-plan GitLab.com-simulation group (GITLAB_SIMULATE_SAAS=1 gdk start).
  2. Confirm the CTA at [data-testid="dap-monthly-credit-card-cta-button"] links to .../subscriptions/purchases/gitlab?deployment_type=gitlab_com&gl_namespace_id=<id>&plan_type=gitlab_credits with no quantity= query parameter.
  3. Confirm the /-/track_cart_abandonment/... POST still fires when the CTA is clicked (the axios call is not experiment-owned and stays; the Jest spec covers it).

Post-merge steps (human)

After this MR deploys:

  1. Prefix the cleanup issue's ## Footprint section with **Cleaned up by <MR URL>.** and add this MR.
  2. Post the outcome on the rollout issue: invalidated → reverted; cleanup MR URL; nothing kept.
  3. Run chatops: /chatops gitlab run feature set change_dap_land_default_credits false (production and --staging) to clear the Flipper gate, then /chatops gitlab run feature delete change_dap_land_default_credits on each to remove the flag record.
  4. Close the rollout issue and the cleanup issue.

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab/-/issues/632416

Edited by Roy Liu

Merge request reports