Skip to content
Snippets Groups Projects

Refactor Epic mutations base

Merged Eugenia Grieff requested to merge 36309-graphql-refactor-epic-mutations-base into master
All threads resolved!

What does this MR do?

Moves re-used epic field and arguments to the base mutation so they can be included in other mutations inheriting from Mutations::Epics::Base.

These changes would aim the work in progress here: !25987 (merged). And the downside is that some descriptions would be more generic.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 11 Errors
    :no_entry_sign: 5aaf0abb: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body
    :no_entry_sign: fb487ae6: The commit subject must not end with a period
    :no_entry_sign: 503e3859: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body
    :no_entry_sign: c77c273e: The commit body should not contain more than 72 characters per line
    :no_entry_sign: 8cda693d: The commit subject must contain at least 3 words
    :no_entry_sign: b21cdd92: The commit subject must start with a capital letter
    :no_entry_sign: b21cdd92: The commit subject must not end with a period
    :no_entry_sign: d9f401c4: The commit subject may not be longer than 72 characters
    :no_entry_sign: d9f401c4: The commit subject must start with a capital letter
    :no_entry_sign: e6149394: The commit subject must not end with a period
    :no_entry_sign: This merge request includes more than 10 commits. Please rebase these commits into a smaller number of commits or split this merge request into multiple smaller merge requests.
    15 Warnings
    :warning: This merge request is definitely too big (more than 7080 lines changed), please split it into multiple merge requests.
    :warning: This merge request changed files with disabled eslint rules. Please consider fixing them.
    :warning: 38edfa82: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: 159749ed: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: 47de47a0: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: d9c303ad: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: ff8bef4d: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: e65dc7e3: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: 533e011b: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: 531c4deb: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: 40bf2335: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: d4254a14: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: 9035b5b6: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: 0f657ee8: The commit subject length is acceptable, but please try to reduce it to 50 characters.
    :warning: Please add a throughput label to this merge request.
    1 Message
    :book: This merge request adds or changes files that require a review from the Database team.

    Disabled eslint rules

    The following files have disabled eslint rules. Please consider fixing them:

    • ee/app/assets/javascripts/security_dashboard/store/modules/unscanned_projects/utils.js

    Run the following command for more details

    node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
      'ee/app/assets/javascripts/security_dashboard/store/modules/unscanned_projects/utils.js'

    This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

    1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
    2. Prepare your MR for database review according to the docs.
    3. Assign and mention the database reviewer suggested by Reviewer Roulette.

    The following files require a review from the Database team:

    • db/migrate/20180305144721_add_privileged_to_runner.rb
    • db/migrate/20180423204600_add_pages_access_level_to_project_feature.rb
    • db/migrate/20180529093006_ensure_remote_mirror_columns.rb
    • db/migrate/20180601213245_add_deploy_strategy_to_project_auto_devops.rb
    • db/migrate/20180831164905_add_common_to_prometheus_metrics.rb
    • db/migrate/20180907015926_add_legacy_abac_to_cluster_providers_gcp.rb
    • db/migrate/20181017001059_add_cluster_type_to_clusters.rb
    • db/migrate/20190218134158_add_masked_to_ci_variables.rb
    • db/migrate/20190218134209_add_masked_to_ci_group_variables.rb
    • db/migrate/20190220142344_add_email_header_and_footer_enabled_flag_to_appearances_table.rb
    • db/migrate/20190228192410_add_multi_line_attributes_to_suggestion.rb
    • db/migrate/20190322164830_add_auto_ssl_enabled_to_pages_domain.rb
    • db/migrate/20190325165127_add_managed_to_cluster.rb
    • db/migrate/20190415030217_add_variable_type_to_ci_variables.rb
    • db/migrate/20190416185130_add_merge_train_enabled_to_ci_cd_settings.rb
    • db/migrate/20190416213556_add_variable_type_to_ci_group_variables.rb
    • db/migrate/20190416213631_add_variable_type_to_ci_pipeline_schedule_variables.rb
    • db/migrate/20190426180107_add_deployment_events_to_services.rb
    • db/migrate/20190520200123_add_rule_type_to_approval_merge_request_approval_rules.rb
    • db/migrate/20190607085356_add_source_to_pages_domains.rb
    • db/migrate/20190628145246_add_strategies_to_operations_feature_flag_scopes.rb
    • db/migrate/20190709204413_add_rule_type_to_approval_project_rules.rb
    • db/migrate/20190712064021_add_namespace_per_environment_flag_to_clusters.rb
    • db/migrate/20190715173819_add_object_storage_flag_to_geo_node.rb
    • db/migrate/20190729180447_add_merge_requests_require_code_owner_approval_to_protected_branches.rb
    • db/migrate/20190816151221_add_active_jobs_limit_to_plans.rb
    • db/migrate/20190901174200_add_max_issue_count_to_list.rb
    • db/migrate/20190905140605_add_cloud_run_to_clusters_providers_gcp.rb
    • db/migrate/20190907184714_add_show_whitespace_in_diffs_to_user_preferences.rb
    • db/migrate/20190918104731_add_cleanup_status_to_cluster.rb
    • db/migrate/20191014123159_add_expire_notification_delivered_to_personal_access_tokens.rb
    • db/migrate/20191023093207_add_comment_actions_to_services.rb
    • db/migrate/20191028130054_add_max_issue_weight_to_list.rb
    • db/migrate/20191029191901_add_enabled_to_grafana_integrations.rb
    • db/migrate/20191105155113_add_secret_to_snippet.rb
    • db/migrate/20191106144901_add_state_to_merge_trains.rb
    • db/migrate/20191112090226_add_artifacts_to_ci_build_need.rb
    • db/migrate/20191121193110_add_issue_links_type.rb
    • db/migrate/20191127163053_add_confidential_to_doorkeeper_application.rb
    • db/migrate/20191127221608_add_wildcard_and_domain_type_to_pages_domains.rb
    • db/migrate/20191129134844_add_broadcast_type_to_broadcast_message.rb
    • db/migrate/20191218124915_add_repository_storage_to_snippets.rb
    • db/migrate/20191218125015_add_storage_version_to_snippets.rb
    • db/migrate/20200122161638_add_deploy_token_type_to_deploy_tokens.rb
    • db/migrate/20200128184209_add_usage_to_pages_domains.rb
    • db/migrate/20200224163804_add_version_to_feature_flags_table.rb
    • db/post_migrate/20200120083607_remove_storage_version_column_from_snippets.rb
    • db/post_migrate/20200127111953_cleanup_empty_snippet_user_mentions.rb
    • db/post_migrate/20200127131953_migrate_snippet_mentions_to_db.rb
    • db/post_migrate/20200127141953_add_temporary_snippet_notes_with_mentions_index.rb
    • db/post_migrate/20200127151953_migrate_snippet_notes_mentions_to_db.rb
    • db/post_migrate/20200221142216_remove_repository_storage_from_snippets.rb
    • db/schema.rb
    • ee/app/finders/packages/packages_finder.rb
    • ee/db/geo/migrate/20170606155045_add_needs_resync_to_project_registry.rb
    • ee/db/geo/migrate/20171009162208_add_file_registry_success.rb
    • ee/db/geo/migrate/20180323182105_add_missing_on_primary_to_file_registry.rb
    • ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb
    • lib/gitlab/background_migration/user_mentions/models/snippet.rb
    • lib/gitlab/background_migration/user_mentions/models/snippet_user_mention.rb
    • rubocop/cop/migration/add_column_with_default.rb

    Commit message standards

    One or more commit messages do not meet our Git commit message standards.

    For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.

    Here is an example of a good commit message:

    Reject ruby interpolation in externalized strings
    
    When using ruby interpolation in externalized strings, they can't be
    detected. Which means they will never be presented to be translated.
    
    To mix variables into translations we need to use `sprintf`
    instead.
    
    Instead of:
    
        _("Hello #{subject}")
    
    Use:
    
        _("Hello %{subject}") % { subject: 'world' }

    This is an example of a bad commit message:

    updated README.md

    This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Etienne Baqué (@ebaque) Ash McKenzie (@ashmckenzie)
    frontend Vitaly Slobodin (@vitallium) Kushal Pandya (@kushalpandya)
    database Tiger Watson (@tigerwnz) Mayra Cabrera (@mayra-cabrera)
    QA Tomislav Nikić (@tmslvnkc) Ramya Authappan (@at.ramya)
    Engineering Productivity for CI, Danger Mark Fletcher (@markglenfletcher) No maintainer available
    test Quality for spec/features/* No reviewer available No maintainer available

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • assigned to @cablett

  • charlie ablett approved this merge request

    approved this merge request

  • assigned to @jarka

  • unassigned @jarka

  • Eugenia Grieff added 1 commit

    added 1 commit

    • 06491459 - Change iid argument type for epics mutation

    Compare with previous version

  • Eugenia Grieff added 179 commits

    added 179 commits

    Compare with previous version

  • assigned to @jarka

  • Eugenia Grieff added 49 commits

    added 49 commits

    Compare with previous version

  • added workflowin review label and removed workflowin dev label

  • charlie ablett mentioned in issue #208394

    mentioned in issue #208394

  • Jarka Košanová resolved all threads

    resolved all threads

  • Thanks @egrieff and @cablett!

  • Jarka Košanová enabled an automatic merge when the pipeline for 1e7b9eee succeeds

    enabled an automatic merge when the pipeline for 1e7b9eee succeeds

  • mentioned in commit bb93702a

  • Eugenia Grieff mentioned in merge request !25628 (merged)

    mentioned in merge request !25628 (merged)

  • added workflowstaging label and removed workflowin review label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading