Use stubbed records instead of doubles in CrossProjectReference spec

Anish Kumarrequested to merge
gitlab-community/gitlab-org/gitlab:anishisbusy/598092-cross-project-ref-build-stubbed into master

What does this MR do and why?

spec/lib/banzai/cross_project_reference_spec.rb used plain double objects for the project, group and user in context and for the referenced project. A review in !230850 (merged) suggested a factory record instead of double for the user; the author kept double only for consistency with the rest of the file. This MR swaps every double in the file for build_stubbed records, so the file stays consistent, needs no database writes, and can be removed from the RSpec/VerifiedDoubles RuboCop todo list.

Closes #598092.

References

Follow-up from !230850 (merged).

Screenshots or screen recordings

Not applicable — spec-only change.

How to set up and validate locally

  1. Run bundle exec rspec spec/lib/banzai/cross_project_reference_spec.rb.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist.

This contribution was prepared with the help of an AI assistant. I reviewed the changes and take responsibility for them.

Merge request reports