Skip to content

Use Label#scoped_label_key when determining scope

Heinrich Lee Yu requested to merge 208021-fix-scoped-labels-scope into master

What does this MR do?

This changes rendering scoped labels to depend on scoped_label_key (which is used to determine scope label exclusivity) when splitting the label title.

This unifies our scoped label name splitting logic and fixes a bug where labels with multiple :: were not split properly.

This is how it looks now:

Screen_Shot_2020-02-26_at_2.14.24_PM

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

#208021 (moved)

Edited by Heinrich Lee Yu

Merge request reports