Loading
Skip commit pipeline summary when pipeline has no iid
Why
Some pipelines don't have an iid. Imports don't assign a new iid, so a pipeline imported without one keeps it nil, and some older pipelines are also missing one. On the commit page, the pipeline summary renders for the commit's last pipeline without checking for an iid. When there isn't one, the page leaves out data-iid, and the frontend sends the getPipelineSummary GraphQL query without $iid. The server rejects every one of these queries with Variable $iid of type ID! was provided invalid value.
What
- Render the pipeline summary on the commit page only when the last pipeline has an iid.
- Add a view spec for the case where the iid is nil.
- Update the existing example so it also checks
data-iid.
Related
Edited by Hunter Stewart