Split cluster info page into tabs
What does this MR do?
It organizes the content of the cluster information page into tabs.
Screenshots
| Tab | Screenshot |
|---|---|
| Details |  |
| Environments |  |
| Health |  |
| Applications |  |
| Advanced Settings |  |
Does this MR meet the acceptance criteria?
Conformity
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Merge request reports
Activity
changed milestone to %12.9
added frontend groupconfigure [DEPRECATED] typefeature labels
Resolved by Maria Vrachni@mnearents @mvrachni @tauriedavis: I want to request your UX feedback here. The purpose of this MR is to introduce the cluster-info page’s tabs design while keeping the current design of each tab’s content. I have a goal of introducing as few changes as possible.
Besides your general feedback, I have one question about the details tab. I noticed that when I click "Save Changes" in the GitLab Integration form and the Provider Details form, both forms perform the same action. In other words, those two forms could be a single form. Is that something we can take advantage of?
- Last reply by Maria Vrachni
added 249 commits
-
5de11124...1df62a12 - 248 commits from branch
master - 486bf8a3 - Split cluster info page into tabs
-
5de11124...1df62a12 - 248 commits from branch
added 2 commits
added 2 commits
added 2 commits
added database databasereview pending labels
mentioned in issue #196064 (closed)
removed database databasereview pending labels
added 1085 commits
-
c5a5eab8...84836fef - 1082 commits from branch
master - 15c43232 - Split cluster info page into tabs
- 9baaeacf - Update cluster info page feature tests
- fc931527 - Move show_cluster_health_graphs helper to foss dir
Toggle commit list-
c5a5eab8...84836fef - 1082 commits from branch
added 2 commits
added 2 commits
added 2 commits
added 2 commits
added 2 commits
added 2 commits
added 2 commits
added 2 commits
added 100 commits
-
cd3bbe8e...db0d1c9b - 98 commits from branch
master - 46b8a026 - Split cluster info page into tabs
- 7f449950 - Update cluster info page feature tests
-
cd3bbe8e...db0d1c9b - 98 commits from branch
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Illya Klymov ( @xanf)Fatih Acet ( @fatihacet)backend Mark Chao ( @lulalala)Ash McKenzie ( @ashmckenzie)test Quality for spec/features/*No reviewer available No maintainer available QA Désirée Chevalier ( @dchevalier2)Dan Davison ( @ddavison)Generated by
Edited by 🤖 GitLab Bot 🤖- Resolved by Taurie Davis
- Last reply by Taurie Davis
assigned to @xanf, @toupeira, and @dchevalier2
assigned to @mnearents
unassigned @toupeira
- Resolved by Enrique Alcántara
@ealcantara Thank you, this is a great one and a significant improvement to UX (Fun fact: I was playing a lot with kubernetes on my side project so I know the pain of old UI)
I have one non-blocking suggestion, feel free to apply or ignore. Meanwhile, I'll approve it
- Last reply by Enrique Alcántara
mentioned in issue gitlab-com/www-gitlab-com#6236 (closed)
- Resolved by Kushal Pandya
@dbalexandre: Could you review this MR, please?
- Last reply by Douglas Barbosa Alexandre
assigned to @dbalexandre
added 337 commits
-
7f449950...9b144771 - 335 commits from branch
master - e9ff0708 - Split cluster info page into tabs
- 73d27fb1 - Update cluster info page feature tests
-
7f449950...9b144771 - 335 commits from branch
assigned to @mvrachni and unassigned @mnearents
unassigned @xanf
assigned to @mnearents and unassigned @mvrachni
added 2 commits
unassigned @dbalexandre
added 2 commits
added 197 commits
-
adf66284...f3ed181b - 194 commits from branch
master - 3991c5d9 - Split cluster info page into tabs
- 5839ce09 - Update cluster info page feature tests
- 4e9126ed - Add changelog entry
Toggle commit list-
adf66284...f3ed181b - 194 commits from branch
added 2 commits
added 199 commits
-
359b9789...4308790b - 196 commits from branch
master - e3e57382 - Split cluster info page into tabs
- 61096fe2 - Update cluster info page feature tests
- 4f188cfb - Add changelog entry
Toggle commit list-
359b9789...4308790b - 196 commits from branch
added 2 commits
assigned to @dbalexandre
- Resolved by Kushal Pandya
@fatihacet: Could you review this Merge Request, please?
- Last reply by Enrique Alcántara
assigned to @fatihacet
unassigned @dbalexandre
assigned to @kushalpandya
unassigned @kushalpandya and @fatihacet
assigned to @kushalpandya and unassigned @mnearents
unassigned @kushalpandya
assigned to @kushalpandya
-
The
package-and-qajob from pipeline https://gitlab.com/gitlab-org/gitlab/pipelines/125645704 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/pipelines/125654731 downstream. -
The
Trigger:qa-testjob from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/pipelines/125654731 triggered https://gitlab.com/gitlab-org/gitlab-qa/pipelines/125677155 downstream. -
The
gitlab-qadownstream pipeline passed.
enabled an automatic merge when the pipeline for d44c6473 succeeds
mentioned in issue gitlab-com/www-gitlab-com#5207 (closed)
mentioned in commit 24730b03
mentioned in issue #196059 (closed)
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added groupenvironments label and removed groupconfigure [DEPRECATED] label
