Remove stale pending skips from snippet service specs

Hady Elamirrequested to merge
gitlab-community/gitlab-org/gitlab:remove-stale-pending-snippet-specs into master

What does this MR do and why?

Removes stale pending test skips from the snippet search service specs.

The pending cases were originally skipped for GitLab issue #32645, which has been resolved. The tests can now run as regular assertions without the old pending machinery.

Changes

  • Remove the pendings list and pending? helper from ee/spec/services/ee/search/snippet_service_spec.rb.
  • Remove pending: pending? from the expect_search_results call.
  • Remove the unused pending: parameter and pending(...) call from ee/spec/support/helpers/search_results_helpers.rb.

References

Closes #594042 (closed)

Screenshots or screen recordings

Not applicable — this MR only changes test/spec code and does not affect the UI.

How to set up and validate locally

Run:

bundle exec rspec ee/spec/services/ee/search/snippet_service_spec.rb

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports