Backport of 'Fix file tree links missing relative URL root' to 19.4

What does this MR do and why?

Backport of !258829 (merged).

The repository file tree browser built each file and directory link with an absolute path passed to new URL(path, gon.gitlab_url). Because the path is absolute, the URL constructor keeps only the origin and drops the relative URL root (a context path such as /gitlab). On instances served under a relative URL root, opening a file or folder in a new tab, middle-clicking, or copying the link returned a 404. The fix builds the link from the projectPath() path helper, which already carries the relative URL root and the organization prefix.

Note: the originating merge request is not yet merged. This backport tracks its current state and should only be merged after that MR merges and deploys to GitLab.com.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, request help in the #s_developer_experience Slack channel to confirm the failures are unrelated to the merge request.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stan Hu

Merge request reports

Loading
Loading