Remove secrets_manager and group_secrets_manager flags
What does this MR do and why?
Removes the secrets_manager (project-level) and group_secrets_manager (group-level) feature flags. Both are type: beta and default_enabled: true.
Secrets Manager goes GA in GitLab 19.5. These two flags were the original gates for the feature and have been default on for a long time.
After this MR, Secrets Manager availability depends only on two gates: the native_secrets_management license and enrollment (namespace enrollment on GitLab.com, instance enrollment on GitLab Self-Managed). This logic lives in SecretsManagement::Availability (ee/lib/secrets_management/availability.rb).
This is the first of several MRs that remove the Secrets Manager feature flags for GA. The flags are split into separate MRs to keep each review small.
All MRs in this series
secrets_manager,group_secrets_manager: !259222 (merged) (this MR)- Enrollment flags (
secrets_manager_namespace_enrollment,secrets_manager_instance_enrollment): !260090 (merged) secrets_manager_async_audit_logs: !260091 (merged)- Billing event flags (
secrets_manager_emit_secret_read_events,secrets_manager_emit_secret_stored_events): !260092 (merged) secrets_manager_denial_telemetry: !260094 (merged)secrets_manager_paid_experience: !260110 (merged)
secrets_manager_api_access stays in beta and default disabled for GA, so it is not part of this series.
Also note: end_secrets_manager_beta_program is removed in !258441 (merged).
Changes
availability.rb: drop both flag checks.ee/lib/secrets_management/rake_task/seed.rb: the GDK seed task no longer enables the two flags.- Delete both flag YAML definitions.
- Specs: remove stubs for the two flags and delete the "feature flag is disabled" contexts. All other test cases are kept.
.gitlab/ci/test-on-cng/main.gitlab-ci.yml: remove the two flags fromQA_FEATURE_FLAGSin thecng-secrets-managerjob.- No doc changes. !258813 (merged) removes all feature flag mentions from the Secrets Manager docs, so the docs still mention these flags until that MR merges.
Impact
- No behavior change for instances that use the default flag state. Both flags are already on.
- An instance that explicitly turned either flag off will now get Secrets Manager if it is licensed and enrolled. Enrollment is opt-in and off by default, so nothing turns on by itself.
- No database migrations. No database changes.
- Changelog: commit trailer
Changelog: otherandEE: true.
After merge
- Delete the flags from all environments:
/chatops gitlab run feature delete secrets_manager group_secrets_manager --dev --pre --staging --staging-ref --production
References
- Related to #474432 (closed) (rollout issue for
secrets_manager) - Related to #578534 (closed) (rollout issue for
group_secrets_manager) - GA epic: &10723
Screenshots or screen recordings
Not applicable. No UI change.
How to set up and validate locally
- Check out the branch and restart Rails.
- In a Rails console, with a licensed and enrolled instance (
Gitlab::CurrentSettings.secrets_manager_instance_enrolledistrue), check thatSecretsManagement::Availability.for_project?(project)andSecretsManagement::Availability.for_group?(group)returntruewithout any feature flag set. - Run the changed specs, for example
bundle exec rspec ee/spec/lib/secrets_management/availability_spec.rb.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.