Skip to content

Pass correct Time object to VSM DataCollector

Adam Hegyi requested to merge fix-vsm-created-at-filter-condition into master

What does this MR do?

Pass correct Time object to Cycle Analytics (Value Stream Management) DataCollector

This change makes sure that the underlying query works properly if Date parameters are given:

  • The created_after parameter will be casted to Time to have the beginning of the day time.
  • The created_before parameter will be casted to Time to have the end of the day time.

Why:

Issue.where('created_at <= ?', '2019-01-01') 

This query will not match the issues created at 2019-01-01 10:00

After this change:

Issue.where('created_at <= ?', '2019-01-01 23:59:59') 

I had to update a few feature test cases because they became "unstable".

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports