Remove ingest_malware_advisories feature flag

Bala Kumarrequested to merge
remove-ff-ingest-malware-advisories into master

What

Remove the ingest_malware_advisories flag so synced malware advisories are always upserted into the pm_malware_* tables.

Why

The database upsert has run enabled-by-default in production since Beta. The flag is no longer needed for GA.

Changes

  • Delete the flag definition from the feature flags YAML
  • In PackageMetadata::MalwareAdvisoryIngestionService#execute, remove the early-return flag guard
  • Delete the now-unused log_upsert_skipped helper method
  • Remove specs for the disabled-state codepath

Testing

Flag-enabled and flag-disabled specs were updated (disabled-state contexts removed). Affected specs pass locally.

Related

Merge request reports