Remove sync_malware_advisories feature flag

Bala Kumarrequested to merge
remove-ff-sync-malware-advisories into master

What

Remove the sync_malware_advisories flag so the malware advisory sync worker always runs.

Why

The malware advisory sync has run enabled-by-default in production since Beta. The flag is no longer needed for GA.

Changes

  • Delete the flag definition from the feature flags YAML
  • In PackageMetadata::MalwareAdvisoriesSyncWorker, remove the flag check from should_run? and delete the sync_flag_enabled? helper method
  • Remove specs for the disabled-state codepath
  • The worker continues to respect existing gates: the Ultimate dependency_scanning license or dependency-firewall availability, and the development guard

Testing

Flag-enabled and flag-disabled specs were updated (disabled-state contexts removed). Affected specs pass locally.

Related

Merge request reports