Remove fix_scan_result_policy_violation_reconciliation flag

Alan (Maciej) Paruszewskirequested to merge
fix/remove-scan-result-policy-violation-reconciliation-flag into master

What does this MR do?

Removes the fix_scan_result_policy_violation_reconciliation feature flag and always runs the reconciliation in Security::SecurityOrchestrationPolicies::UpdateViolationsService.

The flag is already enabled on GitLab.com and all other environments, so behaviour does not change there.

  • Deletes the flag definition.
  • Drops the reconciliation_fix_enabled? guards from the service.
  • Removes the "flag disabled" contexts from the service spec.

Rollout issue: #630688 (closed) Introduced by: !250868 (merged)

How to verify

bundle exec rspec ee/spec/services/security/security_orchestration_policies/update_violations_service_spec.rb

57 examples, 0 failures.

Merge request reports